further cleanup of repo

.Experimental/CVRLuaToolsExtension/LuaToolsExtension/Extensions/CVRBaseLuaBehaviourExtensions.cs

@@ -0,0 +1,47 @@
+using ABI_RC.Core.Player;
+using ABI_RC.Core.Savior;
+using ABI.CCK.Components;
+using ABI.Scripting.CVRSTL.Common;
+using UnityEngine;
+
+namespace NAK.CVRLuaToolsExtension;
+
+public static class CVRBaseLuaBehaviourExtensions
+{
+    // check if the script is eligible for hot reload
+    public static bool IsScriptEligibleForHotReload(this CVRBaseLuaBehaviour script)
+    {
+        return script.Context.IsWornByMe // avatar if worn
+               || script.Context.IsSpawnedByMe // prop if spawned
+               || script.Context.objContext == CVRLuaObjectContext.WORLD; // always world scripts
+    }
+    
+    // gets the asset id from the script
+    public static string GetAssetIdFromScript(this CVRBaseLuaBehaviour script)
+    {
+        switch (script.Context.objContext)
+        {
+            case CVRLuaObjectContext.WORLD:
+                //return MetaPort.Instance.CurrentWorldId; // do not trust CVRAssetInfo, can be destroyed at runtime
+                return "SYSTEM"; // default for world scripts is SYSTEM, but TODO: use actual world id
+            case CVRLuaObjectContext.AVATAR:
+                Component rootComponent = script.Context.RootComponent;
+                return rootComponent switch
+                {
+                    PlayerSetup => MetaPort.Instance.currentAvatarGuid, // local avatar
+                    PuppetMaster puppetMaster => puppetMaster.CVRPlayerEntity.AvatarId, // remote avatar
+                    _ => string.Empty // fuck
+                };
+            case CVRLuaObjectContext.PROP:
+            {
+                CVRSpawnable spawnable = (CVRSpawnable)script.Context.RootComponent;
+                if (!string.IsNullOrEmpty(spawnable.guid)) return spawnable.guid; // after filtering has occured
+                return spawnable.TryGetComponent(out CVRAssetInfo assetInfo) 
+                    ? assetInfo.objectId // before filtering has occured
+                    : string.Empty; // well shit
+            }
+            default:
+                throw new ArgumentOutOfRangeException();
+        }
+    }
+}

.Experimental/CVRLuaToolsExtension/LuaToolsExtension/Extensions/CVRLuaClientBehaviourExtensions.cs

@@ -0,0 +1,128 @@
+using ABI.CCK.Components;
+using ABI.Scripting.CVRSTL.Client;
+using System.Diagnostics;
+using MTJobSystem;
+using UnityEngine;
+
+namespace NAK.CVRLuaToolsExtension;
+
+public static class CVRLuaClientBehaviourExtensions
+{
+    internal static readonly Dictionary<CVRLuaClientBehaviour, bool> _isRestarting = new();
+    private static string PersistentDataPath;
+
+    #region Public Methods
+    
+    public static void Restart(this CVRLuaClientBehaviour behaviour)
+    {
+        PersistentDataPath ??= Application.persistentDataPath; // needs to be set on main
+        
+        if (_isRestarting.TryGetValue(behaviour, out bool isRestarting) && isRestarting)
+        {
+            CVRLuaToolsExtensionMod.Logger.Warning($"Restart is already in progress for {behaviour.ScriptName}.");
+            return;
+        }
+
+        _isRestarting[behaviour] = true;
+
+        bool wasEnabled = behaviour.enabled;
+        if (behaviour.Crashed)
+        {
+            CVRLuaToolsExtensionMod.Logger.Warning($"Restarting a script ({behaviour.ScriptName}) in a crashed state. Unable to determine original enabled state, defaulting to true.");
+            wasEnabled = true;
+        }
+        
+        behaviour.enabled = false;
+        
+        Task.Run(() =>
+        {
+            try
+            {
+                behaviour.ResetScriptCompletely();
+                if (CVRLuaToolsExtensionMod.EntryAttemptInitOffMainThread.Value)
+                {
+                    CVRLuaToolsExtensionMod.Logger.Warning("Attempting to initialize the lua script off main thread. This may cause crashes or corruption if you are accessing UnityEngine Objects outside of Unity's callbacks!");
+                    behaviour.DoInitialLoadOfScript();
+                }
+            }
+            catch (Exception e)
+            {
+                CVRLuaToolsExtensionMod.Logger.Error(e); // don't wanna die in task
+            }
+            
+            MTJobManager.RunOnMainThread("RestartScript", () =>
+            {
+                Stopwatch stopwatch = new();
+                stopwatch.Start();
+
+                try
+                {
+                    if (!CVRLuaToolsExtensionMod.EntryAttemptInitOffMainThread.Value)
+                        behaviour.DoInitialLoadOfScript();
+
+                    if (behaviour.InitialCodeRun) behaviour.IsScriptInitialized = true; // allow callbacks to run again
+                    
+                    // invoke custom event on reset
+                    if (!behaviour.ShouldSkipEvent("CVRLuaTools_OnReset")) behaviour.ExecuteEvent(5000, "CVRLuaTools_OnReset");
+                    
+                    // re-enable the script & invoke the lifecycle events
+                    if (!behaviour.ShouldSkipEvent("Awake")) behaviour.ExecuteEvent(1000, "Awake");
+                    behaviour.enabled = wasEnabled;
+                    if (wasEnabled)
+                    {
+                        if (!behaviour.ShouldSkipEvent("OnEnable")) behaviour.ExecuteEvent(1000, "OnEnable");
+                        if (!behaviour.ShouldSkipEvent("Start")) behaviour.ExecuteEvent(1000, "Start");
+                    }
+                }
+                catch (Exception e)
+                {
+                    CVRLuaToolsExtensionMod.Logger.Error(e); // don't wanna die prior to resetting restart flag
+                }
+
+                _isRestarting.Remove(behaviour);
+                
+                stopwatch.Stop();
+                CVRLuaToolsExtensionMod.Logger.Msg($"Restarted {behaviour.ScriptName} in {stopwatch.ElapsedMilliseconds}ms.");
+            });
+        });
+    }
+    
+    #endregion Public Methods
+
+    #region Private Methods
+    
+    private static void ResetScriptCompletely(this CVRLuaClientBehaviour behaviour)
+    {
+        var boundObjectEntries = new List<LuaScriptFactory.BoundObjectEntry>();
+        foreach (var kvp in behaviour.BoundObjects)
+        {
+            LuaScriptFactory.BoundObjectEntry entry = new(behaviour, behaviour.Context, kvp.Key, kvp.Value);
+            boundObjectEntries.Add(entry);
+        }
+
+        behaviour.IsScriptInitialized = false; // prevent callbacks from causing null refs while restarting
+        behaviour.InitialCodeRun = false; // needs to be set so LoadAndRunScriptIfNeeded will run the script again
+        behaviour.Crashed = false; // reset the crash flag
+
+        behaviour._scriptGlobalFunctions.Clear(); // will be repopulated
+        behaviour._startupMessageQueue.Clear(); // will be repopulated
+        behaviour.LogInfo("[CVRLuaToolsExtension] Resetting script...\n");
+
+        behaviour.script = null;
+        behaviour.script = LuaScriptFactory.ForLuaBehaviour(behaviour, boundObjectEntries, behaviour.gameObject, behaviour.transform, PersistentDataPath);
+                
+        behaviour.InitTimerIfNeeded(); // only null if crashed prior
+        behaviour.script.AttachDebugger(behaviour.timer); // reattach the debugger
+    }
+    
+    private static void DoInitialLoadOfScript(this CVRLuaClientBehaviour behaviour)
+    {
+        behaviour.LogInfo("[CVRLuaToolsExtension] Interpreting " + behaviour.ScriptName + "...\n");
+        behaviour.LoadAndRunScript(behaviour.ScriptText); // fucking slow
+        behaviour.PopulateScriptGlobalFunctionsCache(behaviour.script.Globals); // tbh don't think we need to clear in first place
+        behaviour.HandleMessageQueueEntries(); // shouldn't be any
+        behaviour.InitialCodeRun = true;
+    }
+    
+    #endregion Private Methods
+}